Skip to content

clear out const/let #9878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

clear out const/let #9878

wants to merge 1 commit into from

Conversation

@stpCollabr8nLstn
Copy link
Contributor

@stpCollabr8nLstn stpCollabr8nLstn commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

change let to const/let
change assert.notEqual to assert

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@stpCollabr8nLstn May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
@stpCollabr8nLstn
Copy link
Contributor Author

stpCollabr8nLstn commented Dec 1, 2016

@imyller fixed

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@stpCollabr8nLstn Thank you. Looks good 👍

@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5067/

lpinca
lpinca reviewed Dec 2, 2016
View reviewed changes
test/parallel/test-tls-ecdh.js Outdated
Copy link
Member

@lpinca lpinca Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think it's ok to move the assert require after the common.hasCrypto check.

I'm pointing this out because other tests do this and it would be nice for consistency.
Thanks.

@gibfahn
Copy link
Member

gibfahn commented Dec 2, 2016 •
edited
Loading

@stpCollabr8nLstn The commit author details have your name as amrios. Is this intentional? People normally use their full name.

@stpCollabr8nLstn
Copy link
Contributor Author

stpCollabr8nLstn commented Dec 2, 2016

@gibfahn is there a way to retroactively change that?

@Trott
Copy link
Member

Trott commented Dec 2, 2016

@stpCollabr8nLstn

git commit --no-edit --amend --author="Jane Q. Public <[email protected]>"
git push --force-with-lease origin notMaster

To change it globally so it will be the default for future commits:

git config --global user.name "Jane Q. Public"

@stpCollabr8nLstn
Copy link
Contributor Author

stpCollabr8nLstn commented Dec 2, 2016

thanks @Trott done

@stpCollabr8nLstn @Trott
test: refactor test-tls-ecdh
438abce 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check
@Trott
Copy link
Member

Trott commented Dec 3, 2016

Even though the code shouldn't have changed, it's probably a good practice to always re-run CI after a force push, so....

CI: https://ci.nodejs.org/job/node-test-pull-request/5135/

@targos
Copy link
Member

targos commented Dec 3, 2016

Landed in efa8456.

@targos targos closed this Dec 3, 2016
jasnell
jasnell reviewed Dec 3, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR and for participating in Code and Learn! Welcome to Node.js :-)

targos pushed a commit that referenced this pull request Dec 3, 2016
@stpCollabr8nLstn @targos
test: refactor test-tls-ecdh
efa8456 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check

PR-URL: #9878
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@stpCollabr8nLstn @addaleax
test: refactor test-tls-ecdh
66554c7 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check

PR-URL: #9878
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@stpCollabr8nLstn @addaleax
test: refactor test-tls-ecdh
c9ac2b3 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check

PR-URL: nodejs#9878
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@stpCollabr8nLstn
test: refactor test-tls-ecdh
30cf154 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check

PR-URL: nodejs#9878
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@stpCollabr8nLstn @MylesBorins
test: refactor test-tls-ecdh
2ad4f8d 
clear out const/let
change assert.notEqual to assert
move assert after common.hasCrypto check

PR-URL: #9878
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.